It looks like Peer Code Reviews are on the agenda for quite a few folks at Readify. Darren and I are working on the same engagement at the moment and he has instituted peer code reviews. I was a little hesitant at first because I’ve seen some code reviews come a monumental waste of time but Darren managed to carve out a process that is not only efficient but will probably improve everyones coding skills – mine included.
On Friday I sat down with Darren so he could walk me through the process he had defined for getting my stuff in for code review and we encountered a few kinks that we ironed out there and then. I now eagerly await the feedback from the reviewers since I know there are probably a few rough bits, especially in some of the designer bits which I wrote over twelve months ago.
It seems fellow Readifyian Scott Baldwin also underwent a code review. I think his comments about check-ins and code reviews are completely valid. Code – even if it isn’t perfect is the product of a very expensive resource and should be preserved at all costs. This is why Microsoft has multiple tiers of check-ins before you reach the main Windows trunk with your feature.
Given that there seems to be a bit of discussion about this amongst the Readify folks I thought that maybe as an internal excercise we should all offer up some code for someone in the company to review, just to see how much we can learn from our own individual coding styles. Here is the snippet I am offering up, its from Shrinklet. If anyone is interested – feel free to e-mail me the critique or leave them in the comments.